Added the Bahrain locale (ar-BH) +973 #1003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriso Any chance you can have a quick look at that please ? Unable to work in Bahrain mate. |
|
@chriso Any chance you can have a quick look at that please ? Unable to work in Bahrain mate. |
|
@heiba -- sorry I'm getting to this late, but going to review your PR right away. |
profnandaa
requested changes
Apr 10, 2019
| @@ -40,191 +40,6 @@ function _typeof(obj) { | |||
| return _typeof(obj); | |||
| } | |||
|
|
|||
| function _toArray(arr) { | |||
There was a problem hiding this comment.
See 330ad51. Not sure why they're on master.
profnandaa
added
the
🧹 needs-update
|
@heiba -- any chance you can clean up this PR so that we can have your work in this week? |
|
Hello Anthony,
I'm going to work on this tonight, and will let you know accordingly
whether I managed to finish it or not.
Kind Regards
Mohamed Heiba
…On Tue, 2 Jul 2019 at 20:46, Anthony Nandaa ***@***.***> wrote:
@heiba <https://github.com/heiba> -- any chance you can clean up this PR
so that we can have your work in this week?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1003?email_source=notifications&email_token=ABDQKS3GFU6UW3UZDLIEQ3TP5OH7LA5CNFSM4G6ACBY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCBOYA#issuecomment-507778912>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDQKS2ICU52B3NVHIV635TP5OH7LANCNFSM4G6ACBYQ>
.
|
|
Sounds great, thanks!
…-na
On Tue, Jul 2, 2019 at 8:59 PM Mohamed Heiba <notifications@github.com>
wrote:
Hello Anthony,
I'm going to work on this tonight, and will let you know accordingly
whether I managed to finish it or not.
Kind Regards
Mohamed Heiba
On Tue, 2 Jul 2019 at 20:46, Anthony Nandaa ***@***.***>
wrote:
> @heiba <https://github.com/heiba> -- any chance you can clean up this PR
> so that we can have your work in this week?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#1003?email_source=notifications&email_token=ABDQKS3GFU6UW3UZDLIEQ3TP5OH7LA5CNFSM4G6ACBY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCBOYA#issuecomment-507778912
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABDQKS2ICU52B3NVHIV635TP5OH7LANCNFSM4G6ACBYQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1003?email_source=notifications&email_token=AAB7ZEIVTLKWWH2SX2RXAXLP5OJO5A5CNFSM4G6ACBY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCCSKA#issuecomment-507783464>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB7ZEIKVTFVCDGEZPFCATDP5OJO5ANCNFSM4G6ACBYQ>
.
--
*Nandaa **Anthony*
*,*Software Craftsman & Mentor
*Twitter/Github: *@profnandaa <http://twitter.com/profnandaa>
*Blog: *www.nandaa.com <http://nandaa.com>
|
|
Hello, I have created a new pull request 1056 . I will close this pull request as it is now a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.