Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEmail add host_whitelist option #1912

Closed
TomScavo opened this issue Jan 25, 2022 · 5 comments · Fixed by #1920
Closed

isEmail add host_whitelist option #1912

TomScavo opened this issue Jan 25, 2022 · 5 comments · Fixed by #1920

Comments

@TomScavo
Copy link

No description provided.

@WikiRik
Copy link
Member

WikiRik commented Jan 25, 2022

Can you elaborate on this?

@TomScavo
Copy link
Author

Can you elaborate on this?

In some scenarios, we only allow users to enter a company email address, such as foo@company.com

@WikiRik
Copy link
Member

WikiRik commented Jan 26, 2022

Ah yes, this was already discussed in #1641
If somebody could make a PR to update host_blacklist and host_whitelist of isEmail to be more like the options for isURL that would be nice

@TomScavo
Copy link
Author

I'd like to make a PR for this :)

@WikiRik
Copy link
Member

WikiRik commented Jan 27, 2022

Amazing, go ahead!

This was referenced Jan 31, 2022
Closed
Merged
@TomScavo TomScavo mentioned this issue Feb 7, 2022
Closed
3 tasks
profnandaa pushed a commit that referenced this issue Oct 17, 2022
@poor-cooder
feat(isEmail): add whitelist host to isEmail validation (#1920)
c1d1b48 
closes #1912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@WikiRik @TomScavo