feat(isUrl): urls with empty user (#1833)

* allow urls with empty user * use array extract * reuse auth split
validatorjs · Oct 31, 2021 · ecd94fe · ecd94fe
1 parent c4df647
commit ecd94fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/lib/isURL.js b/src/lib/isURL.js
@@ -111,13 +111,17 @@ export default function isURL(url, options) {
     if (options.disallow_auth) {
       return false;
     }
-    if (split[0] === '' || split[0].substr(0, 1) === ':') {
+    if (split[0] === '') {
       return false;
     }
     auth = split.shift();
     if (auth.indexOf(':') >= 0 && auth.split(':').length > 2) {
       return false;
     }
+    const [user, password] = auth.split(':');
+    if (user === '' && password === '') {
+      return false;
+    }
   }
   hostname = split.join('@');
 

diff --git a/test/validators.js b/test/validators.js
@@ -364,6 +364,7 @@ describe('Validators', () => {
         'http://www.foobar.com/~foobar',
         'http://user:pass@www.foobar.com/',
         'http://user:@www.foobar.com/',
+        'http://:pass@www.foobar.com/',
         'http://user@www.foobar.com',
         'http://127.0.0.1/',
         'http://10.0.0.0/',