fix(isLatLong): fix bug on isLatLang

- when lat starts with (, it makes it a true latitude. - Closes #929
validatorjs · Jul 29, 2019 · 6a1d78d · 6a1d78d
1 parent 54bf8c4
commit 6a1d78d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 1 deletion.
diff --git a/lib/isLatLong.js b/lib/isLatLong.js
@@ -16,6 +16,7 @@ function _default(str) {
   (0, _assertString.default)(str);
   if (!str.includes(',')) return false;
   var pair = str.split(',');
+  if (pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')' || pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(') return false;
   return lat.test(pair[0]) && long.test(pair[1]);
 }
 

diff --git a/src/lib/isLatLong.js b/src/lib/isLatLong.js
@@ -7,5 +7,9 @@ export default function (str) {
   assertString(str);
   if (!str.includes(',')) return false;
   const pair = str.split(',');
+  if (
+    (pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')') ||
+    (pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(')
+  ) return false;
   return lat.test(pair[0]) && long.test(pair[1]);
 }
diff --git a/test/validators.js b/test/validators.js
@@ -6523,6 +6523,8 @@ describe('Validators', () => {
         '-112.96381, -160.96381',
         '-90., -180.',
         '+90.1, -180.1',
+        '(-17.738223, 85.605469',
+        '0.955766, -19.863281)',
         '+,-',
         '(,)',
         ',',

diff --git a/validator.js b/validator.js
@@ -1739,6 +1739,7 @@ var isLatLong = function (str) {
   assertString(str);
   if (!str.includes(',')) return false;
   var pair = str.split(',');
+  if (pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')' || pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(') return false;
   return lat.test(pair[0]) && _long.test(pair[1]);
 };
 

diff --git a/validator.min.js b/validator.min.js