Set minimum version of tough-cookie to 2.3.3 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! @valeriangalliat Are you going to merge and publish this to NPM or shall I do the honor? 😉 |
|
@fabiante please be my guest, as I'm pretty much offline for the next two
weeks 😋
…On Fri., Jun. 21, 2019, 04:02 Fabian Te, ***@***.***> wrote:
Looks good to me!
@valeriangalliat <https://github.com/valeriangalliat> Are you going to
merge and publish this to NPM or shall I do the honor? 😉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37?email_source=notifications&email_token=AA57ILMZPVKOQPBV4J4O4NTP3SDLBA5CNFSM4HWB5IWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHYDSI#issuecomment-504332745>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA57ILM3GMU4DXTEZTRAMMTP3SDLBANCNFSM4HWB5IWA>
.
|
|
Will do next monday / tuesday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
package.jsonto ensure the minimum version of tough-cookie is 2.3.3.v2.3.3 includes salesforce/tough-cookie#97 which addresses a ReDOS vulnerability.
Also modified
test.jsbecause the use ofnotPropertyseemed incorrect and tests were failing - see #36.cc @fabiante