Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/356 lint staged #358

Merged
merged 2 commits into from Jan 18, 2024
Merged

Bugfix/356 lint staged #358

merged 2 commits into from Jan 18, 2024

Conversation

mob8607
Copy link
Collaborator

@mob8607 mob8607 commented Jan 18, 2024

Pull request

Fixes lint-staged handling. I had to keep postcss and eslint with commonJS because they are not supported right now.
The upcoming release of eslint should support it (v9.0), but maybe we therefore need to update our config file: https://eslint.org/docs/latest/use/configure/configuration-files-new

PostCSS seems not to support it out of the box as far as I understood. Maybe we can have a look at that as well.
E.g: postcss/postcss#1773

Ticket

#356

Browser testing

  • add files to git staged and run npm run lint-staged

Checklist

  • I merged the current development branch (before testing)
  • Added JSDoc and styleguide demo
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did run automated tests and linters
  • Did assign ticket
  • Double checked target branch

Review/Test checklist

  • Did review code and documentation
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did check accessibility (Wave, only errors)
  • Re-assign ticket to developer

@mob8607 mob8607 changed the base branch from master to develop January 18, 2024 11:18
@mob8607 mob8607 self-assigned this Jan 18, 2024
@mob8607 mob8607 added bug Something isn't working high priority labels Jan 18, 2024
Copy link
Member

@patric-eberle patric-eberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@patric-eberle patric-eberle merged commit 5c1f994 into develop Jan 18, 2024
@patric-eberle patric-eberle deleted the bugfix/356_lint-staged branch January 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants