Update base image and use latest pygments #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 17.10, not all repositories are available anymore, causing the build to fail when running apt update
|
draft PR, i want to wait until pygments/pygments#1813 is merged and then update the pygments URL with the latest pygments master after that (instead of linking to the fork currently). |
|
My experience is that it can take a really long time for a PR to be merged into the pygments mainstream. Therefore, I would suggest merging this PR now and creating a new one once the pygments PR lands. |
|
there's been some communication back and forth from the original pygments PR author and a maintainer in the last two days, i'd be willing to wait another 1-2 days in the hopes it gets merged soon. |
|
Sounds reasonable ☺ |
dario23
force-pushed
the
update-and-latest-pygments
branch
from
2bfe806
to
e846587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.