feat: add dropdown-indicators Lumo variant to menu-bar button #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
May 6, 2024
...es/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/ltr-dropdown-indicators-small.png
Show resolved
Hide resolved
|
vursen
reviewed
May 7, 2024
There was a problem hiding this comment.
The arrow still seems to be slightly unaligned in tertiary-inline.
There was a problem hiding this comment.
Checked it locally and the pseudo-element is aligned correctly:
Also to me it seems like the arrow looks the same on Mac and Windows. So probably we could keep it this way.
vursen
approved these changes
May 7, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #7345
Based on #7345 (comment)
Type of change
Note
Added
:not([theme='icon'])because this was present in the original "workaround" code snippet.Combining these two variants is probably not a good idea so maybe we could drop this code.