[WIP] refactor: extract some ComboBoxMixin logic to separate mixin #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/combo-box-mixin-split
branch
2 times, most recently
from
9b0e39e
to
067af1d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
force-pushed
the
refactor/combo-box-mixin-split
branch
from
067af1d
to
40ebda6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #5216
This is a first step towards
vaadin-time-pickerrefactoring.I'm going to create a separate, Lit based version of the time-picker using this mixin.
Type of change