fix: Fix failure when Vite sends many messages in sequence #19340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending multiple messages at the same time resulted in java.lang.IllegalStateException: The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state for called method which originates in calling `browserSession.getAsyncRemote().sendText` a second time before the complete callback for the first call has been called. Now the getBasicRemote() method is used instead which blocks until the message has been sent.
|
mcollovati
approved these changes
May 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 9, 2024
Sending multiple messages at the same time resulted in java.lang.IllegalStateException: The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state for called method which originates in calling `browserSession.getAsyncRemote().sendText` a second time before the complete callback for the first call has been called. Now the getBasicRemote() method is used instead which blocks until the message has been sent.
vaadin-bot
added a commit
that referenced
this pull request
May 9, 2024
…19343) Sending multiple messages at the same time resulted in java.lang.IllegalStateException: The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state for called method which originates in calling `browserSession.getAsyncRemote().sendText` a second time before the complete callback for the first call has been called. Now the getBasicRemote() method is used instead which blocks until the message has been sent. Co-authored-by: Artur <artur@vaadin.com>
czp13
reviewed
May 10, 2024
Comment on lines
+57
to
63
| browserSession.getNegotiatedSubprotocol(), msg -> { | ||
| try { | ||
| browserSession.getBasicRemote().sendText(msg); | ||
| } catch (IOException e) { | ||
| getLogger().debug("Error sending message to browser", | ||
| result.getException()); | ||
| e); | ||
| } |
There was a problem hiding this comment.
The only side effect of this PR (I just checked because of copilot Slack discussion), that we will not have debug logs anymore for the sent messages. Potentially it could be added back in case of need.
browserSession.getNegotiatedSubprotocol(), msg -> {
try {
browserSession.getBasicRemote().sendText(msg);
getLogger().debug("Message sent to browser: {}", msg);
} catch (IOException e) {
getLogger().debug("Error sending message to browser",
result.getException());
e);
}
There was a problem hiding this comment.
My bad. I thought it was intentionally removed.
There was a problem hiding this comment.
Thanks Peter for pointing out
There was a problem hiding this comment.
Sorry to intervene with your PR review, Marco. I just checked it because we had internal conversations about this issue in the Copilot channel. Thanks for the review and your kindness, as you always show. 🙇 💙
Artur-
added a commit
that referenced
this pull request
May 10, 2024
Was unintentionally removed in #19340
mcollovati
pushed a commit
that referenced
this pull request
May 10, 2024
Was unintentionally removed in #19340
vaadin-bot
pushed a commit
that referenced
this pull request
May 10, 2024
Was unintentionally removed in #19340
vaadin-bot
added a commit
that referenced
this pull request
May 10, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending multiple messages at the same time resulted in
which originates in calling
browserSession.getAsyncRemote().sendTexta second time before the complete callback for the first call has been called.Now the getBasicRemote() method is used instead which blocks until the message has been sent.