Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not trigger extra TS checks #16523

Merged
merged 1 commit into from Apr 4, 2023
Merged

fix: Do not trigger extra TS checks #16523

merged 1 commit into from Apr 4, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Apr 4, 2023

Fixes the sometimes constant output stream of

[TypeScript] Found 0 errors. Watching for file changes.

The relevant fix in TypeScript is microsoft/TypeScript#51626

@Artur-
fix: Do not trigger extra TS checks
ce0a852 
Fixes the sometimes constant output stream of 
```
[TypeScript] Found 0 errors. Watching for file changes.
```

The relevant fix in TypeScript is microsoft/TypeScript#51626
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test Results

   948 files  ±0     948 suites  ±0   1h 8m 44s ⏱️ + 4m 14s
6 007 tests ±0  5 972 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 260 runs  +5  6 220 ✔️ +5  40 💤 ±0  0 ❌ ±0 

Results for commit ce0a852. ± Comparison against base commit 8e4329a.

@Artur- Artur- self-assigned this Apr 4, 2023
@Artur- Artur- requested a review from czp13 April 4, 2023 09:02
@Artur- Artur- merged commit a65b38c into 24.0 Apr 4, 2023
27 checks passed
@Artur- Artur- deleted the fix-multiple-ts-checks branch April 4, 2023 09:29
vaadin-bot pushed a commit that referenced this pull request Apr 4, 2023
@Artur- @vaadin-bot
fix: Do not trigger extra TS checks (#16523)
e4951af 
Fixes the sometimes constant output stream of 
```
[TypeScript] Found 0 errors. Watching for file changes.
```

The relevant fix in TypeScript is microsoft/TypeScript#51626
vaadin-bot added a commit that referenced this pull request Apr 4, 2023
@vaadin-bot @Artur-
fix: Do not trigger extra TS checks (#16523) (#16525)
457e92f 
Fixes the sometimes constant output stream of 
```
[TypeScript] Found 0 errors. Watching for file changes.
```

The relevant fix in TypeScript is microsoft/TypeScript#51626

Co-authored-by: Artur <artur@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czp13 czp13 czp13 approved these changes

Assignees

@Artur- Artur-

Labels
cherry-picked-23.3 Released with Vaadin 24.0.4 target/23.3 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Artur- @vaadin-bot @czp13