fix: Fix customTheme on IE11 #11811
Merged
fix: Fix customTheme on IE11 #11811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
|
In practice we need calebdwilliams/construct-style-sheets#86 |
|
Or then we would need to get a fix into 2.x for the error that Vlad found in the polyfill there, but I guess 3.x will be fixed earlier. |
caalador
force-pushed
the
issues/11713-custom-theme
branch
from
518c633
to
dd45cb9
Compare
|
the new 3.0.3 works with IE11 and contains the safari fix. Can you @Artur- check safari that it works as expected with 3.0.3 |
|
3.0.3 is quite broken on Safari calebdwilliams/construct-style-sheets#87 |
|
3.0.4 seems to work |
caalador
force-pushed
the
issues/11713-custom-theme
branch
2 times, most recently
from
fe85fd2
to
abf876a
Compare
The construct-style-sheets-polyfill v2 breaks webcomponentsjs polyfill attachShadow. This is not a problem in v3 closes #11713
caalador
force-pushed
the
issues/11713-custom-theme
branch
from
abf876a
to
a6fffab
Compare
Artur-
approved these changes
Oct 15, 2021
caalador
added a commit
that referenced
this pull request
Oct 15, 2021
Update the construct-style-sheets-polyfill to get latest fixes. Relates to #11811
|
SonarQube analysis reported 1 issue
|
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Oct 15, 2021
caalador
added a commit
that referenced
this pull request
Oct 15, 2021
Update the construct-style-sheets-polyfill to get latest fixes. Relates to #11811
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
Update the construct-style-sheets-polyfill to get latest fixes. Relates to #11811
vaadin-bot
added a commit
that referenced
this pull request
Oct 15, 2021
|
This ticket/PR has been released with platform 14.7.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construct-style-sheets-polyfill v2
breaks webcomponentsjs polyfill
attachShadow. This is not a problem in v3
closes #11713