feat: add API to set color options to RichTextEditor #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoobie
reviewed
May 10, 2024
| } | ||
|
|
||
| /** | ||
| * Sets the list of colors used by the text color picker and background |
There was a problem hiding this comment.
What format is required here to be considered a color? hex, hsl, name.. something else? 😀
There was a problem hiding this comment.
Added a mention that colors should be in HEX format (the web component popup uses that).
Note: the actual HTML value produced by Quill uses rgb() so the output looks like this:
<p><span style="color: rgb(230, 0, 0);">Foo</span></p>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to vaadin/web-components#7392
Type of change
Note
Currently
getColorOptions()doesn't return the default value of the corresponding web component property.This could be probably workarounded by adding
notify: trueand using@Synchronizeannotation.