TN-3235 opt-out feature #4337

pbugni · 2023-09-06T23:05:47Z

Monster PR to implement the opt-out feature.
included front end changes from #4335
reused a migration (by altering the order defined within the migration files down_revision variable), and corrected as the previous sequential counts we not keeping up. (TN-3274)

includes implementations for:

pep8speaks · 2023-09-20T21:49:42Z

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/migrations/versions/80c3b1e96c45_.py:

Line 45:101: E501 line too long (105 > 100 characters)
Line 50:101: E501 line too long (103 > 100 characters)
Line 52:1: E302 expected 2 blank lines, found 1
Line 158:101: E501 line too long (118 > 100 characters)

In the file portal/migrations/versions/cf586ed4f043_.py:

Line 19:101: E501 line too long (128 > 100 characters)

In the file tests/fixtures/trigger_state.py:

Line 28:11: E271 multiple spaces after keyword
Line 78:101: E501 line too long (121 > 100 characters)
Line 79:101: E501 line too long (123 > 100 characters)
Line 80:101: E501 line too long (123 > 100 characters)
Line 81:101: E501 line too long (123 > 100 characters)
Line 82:101: E501 line too long (123 > 100 characters)
Line 83:101: E501 line too long (123 > 100 characters)
Line 84:101: E501 line too long (123 > 100 characters)
Line 85:101: E501 line too long (123 > 100 characters)
Line 86:101: E501 line too long (123 > 100 characters)

Comment last updated at 2024-05-13 23:19:41 UTC

…rs, not previous answers!

… counts, so the test db can be switched over to a hotfix without this migration.

…er moving patient timeline.

…consent change.

log rather than blow up, when a finding missing SDC observations.

…g errors. improve logging when trigger_states become out of sync with qb_timeline due to consent change.

…esting

…rom consent changes.

…onths.

…rom_research_study()`

(needed in this PR as a few test users are in a broken state)

…n `_total_opted_out`

…ils.

part of https://movember.atlassian.net/browse/TN-3284 address OPT OUT requirement: `A patient can choose to opt out a maximum of 3 times for a single domain` Changes include: Frontend will now check triggers history to ensure that user had not chosen to opt out of a domain at least 3 times in the past, i.e. check `_total_opted_out` of the domain property. If so, it will not present the domain as an opt out option on UI. --------- Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>

…s, requiring a captcha. Pulled the content to files on the file system.

…e notification emails to clearly show the domains to be contacted about vs those the user requested be left alone.

…t `down_revision` variable).

…ied to send a "reminder" to an all opted-out patient's clinician.

…all trigger APIs.

…ail to all opted out case.

Pin NodeJS version used to build frontend

pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 4a53cde to 9f0b7b9 Compare October 4, 2023 23:49

pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 9f0b7b9 to c4f1acd Compare November 16, 2023 22:47

pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 97cc939 to 5f2645a Compare January 25, 2024 03:00

pbugni force-pushed the feature/sequential-hard-triggers-fix branch 2 times, most recently from e993e23 to ae92158 Compare March 12, 2024 21:30

pbugni added 16 commits March 20, 2024 09:40

TN-3236, sequential hard trigger counts kept in trigger_states.trigge…

17931d2

…rs, not previous answers!

expand migration downgrade step, to remove all sequential hard domain…

2d06578

… counts, so the test db can be switched over to a hotfix without this migration.

add debugging into to exception text

4e6912b

add exception to catch details for bogus records

075506e

add sanity_check() to /timewarp - confirm invariants before and aft…

ea27479

…er moving patient timeline.

rework alembic migration order to reapply hard trigger migration again

d9b576f

refactor to reuse same migration again, with patched code in place

62ba242

refactor email generation to common empro_messages module.

8f0bff9

progress towards regenerating a user's trigger_states table on EMPRO …

04ba858

…consent change.

correct order of migrations with work done outside branch.

a947918

log rather than blow up, when a finding missing SDC observations.

allow for minor EMPRO consent changes and withdrawal calls w/o raisin…

419db4b

…g errors. improve logging when trigger_states become out of sync with qb_timeline due to consent change.

minor refactor typo; initialize variable only set on a match before t…

3cac7bc

…esting

alert on production, purge on dev/test, problem trigger_states rows f…

c7ecaa7

…rom consent changes.

correct spelling for testing SYSTEM_TYPE

c562fe8

typo - TriggerState has timestamp column, not as_of_date

fea4462

incorrect attribute access on previous_triggers.triggers

7f4bb5e

pbugni force-pushed the feature/sequential-hard-triggers-fix branch from 9c29d3b to 7f4bb5e Compare March 20, 2024 16:40

pbugni added 7 commits March 20, 2024 09:59

look for gaps when calling users_trigger_state as users will skip m…

7f2c6ea

…onths.

API for front-end to set opt-out. incomplete work.

89e13ae

creat quick lookup function to determin if a patient has `withdrawn_f…

1c1b21b

…rom_research_study()`

consider withdrawal date when looking up user's latest /triggers

56f1500

implement and tests for persisting opt-out domains.

b7b0722

clear any opt_out domains previously set and not included in API call

f3a9815

include problem patient id in timeline error log

1c96f04

pbugni and others added 18 commits April 16, 2024 16:58

update purge_user to work with additional constraints.

b8402f4

(needed in this PR as a few test users are in a broken state)

accumulate number of times a user has opted out of any given domain i…

ae10c5c

…n `_total_opted_out`

missed request for items() on dictionary iteration.

09881f8

add partially opted out versions of the empro clinician trigger ema…

495d2a4

…ils.

update UUIDs for emails

6a49b78

patch test case, with audit entry not having a defined comment.

a428403

The hl7.org value-sets are no longer available for automated download…

a896e5b

…s, requiring a captcha. Pulled the content to files on the file system.

remove useless empty Coding, which was generating a warning on import.

3e606dd

frontend code fix - fix get EMPRO get triggers ajax call

70ec17a

correct logic around delay when waiting for user feedback on opt_out.

e0bb35f

when user opted out of some but not all domains, limit the list in th…

7e2f6d3

…e notification emails to clearly show the domains to be contacted about vs those the user requested be left alone.

debugging log stmts only

f020f24

debugging log stmts only

1055405

correct logic on delay

3b23d46

add check for no action state

3b0591e

clean up excessive logging

cd49c19

correct comment with migration reordering (previous commit only caugh…

86d6942

…t `down_revision` variable).

pbugni changed the title ~~TN-3236 opt-out feature~~ TN-3235 opt-out feature Apr 23, 2024

pbugni requested review from mcjustin and ivan-c April 23, 2024 18:47

ivan-c approved these changes Apr 29, 2024

View reviewed changes

pbugni and others added 8 commits April 30, 2024 17:50

no smoke, adding logging and tests looking for why the test system tr…

e9b5811

…ied to send a "reminder" to an all opted-out patient's clinician.

as users may enter on email links to file EMPRO, allow such auth for …

774d88d

…all trigger APIs.

another guard clause, still puzzling over attempt to send reminder em…

220b991

…ail to all opted out case.

Pin NodeJS version (#4378)

6ed1f1c

Pin NodeJS version used to build frontend

triggers API call check fix

7dc96e8

add domain existence check, bug fix

1f82e32

label click event fix

aa90540

cut&paste error on adherence report, opt_out change.

4769b7a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TN-3235 opt-out feature #4337

TN-3235 opt-out feature #4337

pbugni commented Sep 6, 2023 •

edited

pep8speaks commented Sep 20, 2023 •

edited

TN-3235 opt-out feature #4337

Are you sure you want to change the base?

TN-3235 opt-out feature #4337

Conversation

pbugni commented Sep 6, 2023 • edited

pep8speaks commented Sep 20, 2023 • edited

Comment last updated at 2024-05-13 23:19:41 UTC

pbugni commented Sep 6, 2023 •

edited

pep8speaks commented Sep 20, 2023 •

edited