Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "perf: remove superfluous call to toLowerCase (#677)" #738

Merged
merged 2 commits into from Oct 11, 2023
Merged

fix: revert "perf: remove superfluous call to toLowerCase (#677)" #738

merged 2 commits into from Oct 11, 2023

Conversation

broofa
Copy link
Member

@broofa broofa commented Oct 11, 2023 •
edited

This reverts commit e53793f per this discussion

ctavan
ctavan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ctavan ctavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to improve the comment in a different CL?

@broofa
Copy link
Member Author

broofa commented Oct 11, 2023

Are you planning to improve the comment in a different CL?

Fixed.

@ctavan
Copy link
Member

ctavan commented Oct 11, 2023

Thanks a lot! LGTM!

@broofa broofa merged commit e267b90 into main Oct 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctavan ctavan ctavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@broofa @ctavan