chore: run node-esmodule package.json test only in latest node LTS #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the breaking CI test. Apparently node@16 now throws if you try to import a .json file with no import assertion. Ref: nodejs/node#40250 cc: @ctavan for sanity check to make sure this won't break anything.
ctavan
changed the title
ctavan
force-pushed
the
test-esm-node-only-on-node-16
branch
from
c919cc3
to
d6e151d
Compare
ctavan
force-pushed
the
test-esm-node-only-on-node-16
branch
from
d6e151d
to
e99c2f6
Compare
ctavan
changed the title
broofa
approved these changes
Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ESM support has been stable in current versions of Node.js 14.x and 16.x, support for importing JSON files is still experimental and evolving.
Since we still want to cover the fact that the package is exporting it's package.json file, this test is now extracted to only run with the updated JSON import syntax which requires import assertions and which was introduced in Node.js 16.14.0.
Fixes #619