Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default export to named function #545

Merged
merged 2 commits into from Jan 4, 2021
Merged

Change default export to named function #545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c555a3
Change default export to named function
dylans Jan 4, 2021
8db9b81
Update v35.js
dylans Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/v35.js
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ function stringToBytes(str) {
export const DNS = '6ba7b810-9dad-11d1-80b4-00c04fd430c8';
export const URL = '6ba7b811-9dad-11d1-80b4-00c04fd430c8';

export default function (name, version, hashfunc) {
function v35(name, version, hashfunc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just export default function v35(…?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer this, I just went with matching what was in src/v4.js 👍

function generateUUID(value, namespace, buf, offset) {
if (typeof value === 'string') {
value = stringToBytes(value);
Expand Down Expand Up @@ -66,3 +66,5 @@ export default function (name, version, hashfunc) {

return generateUUID;
}

export default v35;