[WIP] Upgrade rand 0.5 #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabisurita
requested review from
Dylan-DPC-zz,
kinggoesgaming,
KodrAus and
radix
as code owners
|
Thanks @gabisurita for the PR!! There are few points to go over here:
As such I would suggest closing (master -> breaking merge conflict game is not fun) this PR, and opening another one against |
|
@gabisurita thanks for the PR. However as pointed above, this needs to be targetted to the PS: I have changed the branch to |
Dylan-DPC-zz
added
breaking
Merged
|
This has been superseded by #262 |
kinggoesgaming
added
Wont Fix:Superseded
and removed
breaking
bors bot
added a commit
that referenced
this pull request
Jun 12, 2018
262: update rand to 0.5.x r=Dylan-DPC a=kinggoesgaming # Description Update `rand` to `0.5` and refactor code accordingly # Motivation Regular dependency updates # Tests Curent tests passing # Related Issue(s) supersedes #258 Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Upgrades rand to 0.5, thus enabling stdweb support, among other upgrades. For the full changelog, check https://github.com/rust-lang-nursery/rand/blob/master/CHANGELOG.md#050---2018-05-21.
Related Issue(s)
#257