Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation URLs when using rubocop --show-docs-url #47

Merged
merged 1 commit into from Sep 20, 2022

Conversation

r7kamura
Copy link
Contributor

Added DocumentationBaseURL for rubocop --show-docs-url [COP1,COP2,...] command to work correctly for rubocop-packaging cops.

Before

$ bundle exec rubocop --show-docs-url Packaging/BundlerSetupInTests
https://docs.rubocop.org/rubocop/cops_packaging.html#packagingbundlersetupintests

After

$ bundle exec rubocop --show-docs-url Packaging/BundlerSetupInTests
https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packagingbundlersetupintests

@koic
Copy link
Collaborator

koic commented Aug 24, 2022

Is the following issue resolved?
rubocop/rubocop-rails#756 (comment)

@r7kamura r7kamura changed the title Add DocumentationBaseURL Fix incorrect documentation URLs when using rubocop --show-docs-url Aug 24, 2022
Copy link
Collaborator

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mvz
Copy link
Collaborator

mvz commented Aug 24, 2022

@utkarsh2102 has regular merge been disabled?

@utkarsh2102
Copy link
Owner

Hey @mvz,

@utkarsh2102 has regular merge been disabled?

Not really? I just enabled all 3 options. Isn't that what you see, too? 🤔

@utkarsh2102
Copy link
Owner

Hey @mvz,

@utkarsh2102 has regular merge been disabled?

Not really? I just enabled all 3 options. Isn't that what you see, too? thinking

Bah! I did something stupid - I ticked "Require linear history" box and thus the issue. Fixed. Sorry. :(

Copy link
Owner

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🎉 ❤️

@utkarsh2102 utkarsh2102 merged commit 275fd81 into utkarsh2102:master Sep 20, 2022
@mvz
Copy link
Collaborator

mvz commented Sep 21, 2022

Bah! I did something stupid - I ticked "Require linear history" box and thus the issue. Fixed. Sorry. :(

Thanks for figuring this out @utkarsh2102. Seems like a GitHub UI issue to me 😄.

@koic
Copy link
Collaborator

koic commented Jun 10, 2023

@utkarsh2102 This change only exists in the master branch for a long time. How about cutting a new version to RubyGems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants