Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.4 support #40

Merged
merged 1 commit into from Sep 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
Expand Up @@ -9,7 +9,7 @@ AllCops:
- 'spec/fixtures/**/*'
- 'tmp/**/*'
- 'vendor/**/*'
TargetRubyVersion: 2.4
TargetRubyVersion: 2.5

Naming/FileName:
Exclude:
Expand Down
4 changes: 2 additions & 2 deletions rubocop-packaging.gemspec
Expand Up @@ -21,12 +21,12 @@ Gem::Specification.new do |spec|
spec.files = Dir["config/default.yml", "lib/**/*", "LICENSE", "README.md"]
spec.require_paths = ["lib"]

spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")

spec.add_development_dependency "bump", "~> 0.8"
spec.add_development_dependency "pry", "~> 0.13"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "yard", "~> 0.9"
spec.add_runtime_dependency "rubocop", ">= 0.89", "< 2.0"
spec.add_runtime_dependency "rubocop", ">= 1.13", "< 2.0"
end
3 changes: 1 addition & 2 deletions spec/rubocop/packaging_spec.rb
Expand Up @@ -50,8 +50,7 @@
end
end

it "has a SupportedStyles for all EnforcedStyle " \
"and EnforcedStyle is valid" do
it "has a SupportedStyles for all EnforcedStyle and EnforcedStyle is valid" do
errors = []
cop_names.each do |name|
enforced_styles = config[name]
Expand Down
3 changes: 1 addition & 2 deletions tasks/cops_documentation.rake
Expand Up @@ -25,8 +25,7 @@ task verify_cops_documentation: :generate_cops_documentation do
# Output diff before raising error
sh("GIT_PAGER=cat git diff docs")

warn "The docs directory is out of sync. " \
"Run `rake generate_cops_documentation` and commit the results."
warn "The docs directory is out of sync. Run `rake generate_cops_documentation` and commit the results."
exit!
end
end