Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve depiction of 馃嚭馃嚫 ASCII flag #5886

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anselmbradford
Copy link

@anselmbradford anselmbradford commented Apr 24, 2024

The build system outputs an ASCII flag. The current ASCII flag is missing some stars and stripes! This PR updates the ASCII flag to improve its fidelity. It shows a B/W flag when the build system is started, and a color flag when it has successfully built the USWDS without error. 馃嚭馃嚫馃嚭馃嚫馃嚭馃嚫

To test, run npm install

For reference, see general provisions for the flag image on https://uscode.house.gov/view.xhtml?path=/prelim@title4/chapter1&edition=prelim

Before:
Screenshot 2024-04-24 at 5 55 20 PM

After:
Screenshot 2024-04-24 at 6 44 48 PM

Screenshot 2024-04-24 at 6 44 55 PM

@brunerae brunerae added Needs: Discussion We need to discuss an approach to this issue Status: Triage We're triaging this issue and grooming if necessary labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Discussion We need to discuss an approach to this issue Status: Triage We're triaging this issue and grooming if necessary
Projects
Status: TBD
Development

Successfully merging this pull request may close these issues.

None yet

5 participants