New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS 3.5.0 #5323
USWDS 3.5.0 #5323
Conversation
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
PR Template: Add checklist item for changelog
Since `is_demo` is a storybook control setting it should live in the story, not the component settings.
…wds into cm-disabled-high-contrast
…o cm-disabled-high-contrast
- We did this to prevent users from breaking contrast compliance - We may be able to move this back after providing high contrast documentation to users
…wds into cm-disabled-high-contrast
…wds into cm-disabled-high-contrast
…ed-high-contrast-border mixin
…cessary definitions
@thisisdano I reviewed the release notes in the PR description and had some notes. I am happy to work on edits if it would be helpful - either directly in the description or in a separate markdown file (whichever you prefer). Just let me know. Note: this might be easier to read in edit mode since it doesn't enhance the PR numbers there.
|
USWDS - Remove id from site title
@thisisdano @mejiaj @mahoneycm I have updated the PR description according to my notes above. I'll come back tomorrow morning to take another look and confirm everything looks good. |
Thank you for your careful review @amyleadem! |
Update 3.5.0 with latest from develop
I've updated references from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tested:
- Milestone PRs are listed PR description.
- Milestone PRs are merged in develop branch.
- Release branch is sync'd with develop.
- Vulnerabilities are accurate (
30 vulnerabilities (1 moderate, 29 high) - 06/09/23
) - Changelog PRs match release note PRs.
Looks good to me. Took another look at the description and made a couple small updates related to breaking changes. PR contents:
PR description:
|
I think for these elements that are not technically breaking, we do not mark as breaking, but add a callout in the release notes that there's a recommended change in markup, and call out that change in the notifications file as well. I can do that now. |
Updated breaking or potentially breaking changes with notes and a Current notifications:
|
Added a disabled form controls note:
|
What's new in USWDS 3.5.0
Features
usa-button
,usa-dark-background
,uswds-core
usa-button
,usa-checkbox
,usa-date-picker
,usa-pagination
,usa-radio
,usa-range
,usa-search
,uswds-core
usa-button
,usa-checkbox
,usa-combo-box
,usa-date-picker
,usa-date-range-picker
,usa-file-input
,usa-input
,usa-input-mask
,usa-input-prefix-suffix
,usa-radio
,usa-range
,usa-select
,usa-textarea
,uswds-core
usa-button
,usa-checkbox
,usa-combo-box
,usa-date-picker
,usa-date-range-picker
,usa-file-input
,usa-input
,usa-input-prefix-suffix
,usa-radio
,usa-range
,usa-select
,usa-textarea
,usa-time-picker
,uswds-core
usa-link
,uswds-core
uswds-core
$theme-external-link-sr-label-tab-same
and$theme-external-link-sr-label-tab-new
to control how screen readers announce external links. (#5166)usa-content
,usa-paragraph
,usa-prose
,uswds-core
usa-prose-
mixins and placeholders from Sass. Users should instead usetypeset-
mixins in their place. This is a breaking change only if your project Sass usesusa-prose-
mixins and placeholders. It does not affect the look of anyusa-prose
–styled element.(#5158)uswds-core
$theme-heading-margin-top
and$theme-paragraph-margin-top
system variables. (#5158)uswds-core
false
. Users can now update only the map values they wish to change. This is a breaking change only if your project deactivated mapped settings by not declaring them. (#5216)usa-accordion
,usa-banner
,usa-nav
,uswds-core
$theme-accordion-button-background-color
and$theme-accordion-background-color
. (#5269)Bug fixes
usa-header
id
attribute from theusa-logo
element. (#5319)usa-header
usa-megamenu
class. (#5311)usa-table
uswds-core
,uswds-utilities
usa-tooltip
data-position
attribute is not specified, the tooltip position will now default to "top". (#5228)usa-in-page-navigation
usa-alert
usa-button
type
attribute to render empty. (#5247)usa-button
usa-card
button
elements with links styled as buttons.<a href="#" class="usa-button"></a>
for the call to action instead of abutton
element. (#4385)usa-pagination
role="presentation"
witharia-label="ellipsis indicating non-visible pages"
forusa-pagination__overflow
items to better conform to WCAG 2.0 and 2.1.usa-pagination__overflow
element, usearia-label="ellipsis indicating non-visible pages"
instead ofrole="presentation"
. (#5197)usa-file-input
usa-file-input
usa-combo-box
usa-accordion
,usa-banner
,usa-nav
ButtonText
colors. (#5286)usa-identifier
Dependencies and security
0
vulnerabilities in regular dependencies (dependencies for USWDS projects installed withnpm install uswds
)1 moderate 29 high
vulnerabilities in devDependencies (development dependencies)Related PR
USWDS-Site: Add changelog items for USWDS 3.5.0 #2096
Release TGZ SHA-256 hash:
e0dbab25bffaaf02b3b7317690939d9e0e63bc5c824046e778de8f4c15227a9c