USWDS 3.4.1 #5181
Closed
USWDS 3.4.1 #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USWDS documentation on header says there is a theme setting to adjust the logo text width. It does not work with header-extended. This fixes that. https://designsystem.digital.gov/documentation/settings/ Verify where else this variable is used and if the default value needs to be updated. Documentation says default values 33%, header-extended uses default value 50%
1. better interoperability with project's own handling of the heading tags 2. fix intersection observe re: #5068 (review)
1. avoid eslint warning 2. leverage more purpose-suited do/while vs. while(true) break
Based on questions from review
In-Page Navigation: Update page URL when scrolling to section
USWDS - Links: Fix invisible text when styled as buttons within forms. Resolves #5066
usa-header--extended usa-logo text width: Fixed to work with theme setting
Sync develop 3.4.0
|
Closing in favor of #5182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in USWDS 3.4.1
There were a couple features and bug fixes that we intended to include in USWDS 3.4.0, but inadvertently omitted from that release.
Features and bug fixes
usa-in-page-navigationusa-formusa-buttonclass is present. (#5112)usa-header$theme-header-logo-text-width. Thanks @RSD-accessboard! (#5008)Dependencies and security
No dependency changes
0vulnerabilities in regular dependencies (dependencies for USWDS projects installed withnpm install uswds)1 moderate 33 highvulnerabilities in devDependencies (development dependencies)Release TGZ SHA-256 hash:
af1cd42c60b73fbbfa9c27b8ee52fb735b1a2234c6b3aa17de5bbf8a9190ca62