Beta sass modules - fix module loop in function color() #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this as we decided to use internal function to set theme color. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent module looping, I rebuilt aspects of the function color() so that it points to assignments-theme-color instead of shortcodes-color-project (which is dependent on the color function).
This is still unrefined and I don't fully understand the ramifications of the change on the system, but figured it could be a good conversation starter.
Note: There is a chance the 'set-theme' and 'no-warn' flags were essential for the theme colors to be built correctly, and this scratches those right out.
Color function success criteria