Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Side navigation: Fix current color link color. #4163

Merged
merged 6 commits into from Apr 27, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Apr 21, 2021

Description

Resolves #4073.

The color on usa-current was being overriden due to color setting in over-specific selector a:not(.usa-button). This sets default color on a more specific a:not(.usa-button):not(.usa-current).

Additional information

There's a related feature request #3994 where we hope to revisit Side navigation overall. For example, it'd be better if we had a class like .usa-sidenav__link where we could differentiate sidenav links from other elements.

Test page created for this issue - preview link →


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj requested a review from thisisdano April 23, 2021 16:14
@thisisdano thisisdano merged commit 328cc9d into develop Apr 27, 2021
@thisisdano thisisdano mentioned this pull request Apr 27, 2021
@mejiaj mejiaj deleted the jm-sidenav-current-color branch August 12, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect text color on current items in sidenav
2 participants