USWDS - Side navigation: Fix current color link color. #4163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4073.
The color on
usa-current
was being overriden due to color setting in over-specific selectora:not(.usa-button)
. This sets default color on a more specifica:not(.usa-button):not(.usa-current)
.Additional information
There's a related feature request #3994 where we hope to revisit Side navigation overall. For example, it'd be better if we had a class like
.usa-sidenav__link
where we could differentiate sidenav links from other elements.Test page created for this issue - preview link →
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm test
and make sure the tests for the files you have changed have passed.