Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Packages: Add summary box and update imports list. #4162

Merged
merged 2 commits into from Apr 22, 2021
Merged

USWDS - Packages: Add summary box and update imports list. #4162

merged 2 commits into from Apr 22, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Apr 20, 2021 •
edited

Description

Resolves #4159. Missing package for summary box component.

Additional information

I've also done the following in src/stylesheets/theme/styles.scss:

  • Sorted components alphabetically
  • Added missing components:
    • Collection
    • Icon list
    • Icon
    • Site alert
    • Summary box
  • Removed duplicate Identifier entry

How to test

  1. Checkout branch
  2. npm start
  3. Comment out line 13 in uswds.scss and add @import "packages/usa-summary-box";
  4. Compile SCSS
  5. Visit library preview /components/detail/summary-box.html

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj
Create summary box package.
829cc6c
@mejiaj
Cleanup package imports in styles.scss
55a4e77 
- Remove duplicate entry
- Add missing summary box
- Sort alphabetically
- Add icon and icon list
- Add site alert
- Add collection
scottqueen-bixal
scottqueen-bixal approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed testing process and successfully rendered styles related to our summary-box component as expected.
Screen Shot 2021-04-20 at 9 57 39 AM

@mejiaj mejiaj requested a review from thisisdano April 20, 2021 14:02
@thisisdano thisisdano merged commit 567f7ad into develop Apr 22, 2021
@thisisdano thisisdano deleted the jm-summary-box-package branch April 22, 2021 22:45
@thisisdano thisisdano mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

@scottqueen-bixal scottqueen-bixal scottqueen-bixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary box component not on component packages list in styles.scss
3 participants
@mejiaj @thisisdano @scottqueen-bixal