USWDS - Checkbox & Radio: Display state when disabled and checked. #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked and disabled. added styles for the --tile version.
- Remove extra example - Move radio tile checked back to 1st item
…unchecked-when-disabled-even-when-checked
thisisdano
approved these changes
Apr 22, 2021
thisisdano
reviewed
Apr 22, 2021
| @@ -13,7 +13,7 @@ | |||
| <label class="usa-radio__label" for="historical-washington-2">Booker T. Washington</label> | |||
| </div> | |||
| <div class="usa-radio"> | |||
| <input class="usa-radio__input usa-radio__input--tile" id="historical-carver-2" type="radio" name="historical-figures-2" value="george-washington-carver" disabled> | |||
| <label class="usa-radio__label" for="historical-carver-2">George Washington Carver</label> | |||
| <input class="usa-radio__input usa-radio__input--tile" id="historical-marshall-2" type="radio" name="historical-figures" value="thurgood-marshall" disabled> | |||
There was a problem hiding this comment.
Thank you for changing this as well
thisisdano
approved these changes
Apr 22, 2021
thisisdano
deleted the
je-radio-shows-unchecked-when-disabled-even-when-checked
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3979. More up-to-date version of old PR #4063.
Additional information
How to test: Add
checkedto disabled radio & checkbox inputs.Checkbox
Radio
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.