Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 24px icons only (+ small icon updates) #4139

Merged
merged 9 commits into from Apr 1, 2021
Merged

Use 24px icons only (+ small icon updates) #4139

merged 9 commits into from Apr 1, 2021

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Mar 31, 2021

This PR updates a significant subset of our icons we mistakenly distributed as the 20px version instead of our standard 24px version. Notably, this improves the output of the login icon so now it's consistent with the logout icon.

⚠️ Affects layout: This could the alignment and look of some icons

Old

Screen Shot 2021-03-31 at 1 17 37 PM

New

Screen Shot 2021-03-31 at 1 17 49 PM

Additional changes

  • It also adds the script we use to copy and rename the Material icons (config/rename-material-icons.sh)
  • It moves some social icons into the proper directory
  • Replaces thumb_down_off_alt with thumb_down_alt to be consistent with thumb_up icon
  • Updates camping icon to be more conformant with guidance alignments
  • ⚠️ Breaking: Removes remove_red_eye icon from usa-icons and sprite: Duplicate of visibility

@thisisdano thisisdano changed the title Use 24px icons only Use 24px icons only (+ small icon updates) Mar 31, 2021
@thisisdano thisisdano requested a review from mejiaj March 31, 2021 21:43
@mejiaj mejiaj merged commit 0f1f4d0 into develop Apr 1, 2021
@mejiaj mejiaj deleted the dw-icon-update branch April 1, 2021 14:39
@thisisdano thisisdano mentioned this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants