Issue-3256: Prevent focus outline from being overridden. #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisdano
added
Package: Button
improves: correctness
Type: Bug
Merged
maya
reviewed
Dec 18, 2019
| &:focus, | ||
| &.usa-focus { | ||
| &:not([disabled]):focus, | ||
| &:not([disabled]).usa-focus { |
There was a problem hiding this comment.
why repeat when you can...
&:not([disabled]) {
&:focus,
&.usa-focus {
...
}
}
?
There was a problem hiding this comment.
Stylistic choice, seemed more readable to me.
There was a problem hiding this comment.
Yeah, makes sense. We can fold it into the next block of work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3256
Additional information
https://user-images.githubusercontent.com/11464021/70549602-557bb080-1b29-11ea-8b7a-86d8e76a4f3c.gif
Focus styles in
_buttons.scsswere being overriden by the specificity of:notinsrc/stylesheets/global/_focus.scss:5.Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.