Fix internal page link errors from mobile navigation #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thisisdano I've been bumping up against that bug as well, anything you're missing in this PR that you might need help with? |
|
@RobAWilkinson Does this fix address the bug successfully? It works for me, but I'd been awaiting confirmation from a colleague. |
|
Happy to merge and release it asap |
|
Confirmed that this is working. Will merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview ✨
This PR constrains the scope of the
NAV_CONTROLconst innavigation.jsto buttons only — specificallybutton.${PREFIX}-nav__link. This means that any toggle actions will only apply to actual toggle triggers and not to any links, internal or external.Fixes #3058