Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title to display in vars and mixins #3034

Merged
merged 2 commits into from Apr 16, 2019
Merged

Change title to display in vars and mixins #3034

merged 2 commits into from Apr 16, 2019

Conversation

maya
Copy link
Contributor

@maya maya commented Apr 12, 2019 •
edited

Using title confused people who thought it was meant for the h1. Using display clarifies this and uses commonly accepted typography language.

@maya maya requested a review from a team April 12, 2019 20:06
@maya
Copy link
Contributor Author

maya commented Apr 12, 2019 •
edited

I don't really understand the codeclimate coverage failure here.

@thisisdano thisisdano merged commit 872dbec into develop Apr 16, 2019
@thisisdano thisisdano mentioned this pull request May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maya @thisisdano