Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain focus to tabbable elements [IE 11 fix] #2988

Merged
merged 1 commit into from Mar 25, 2019
Merged

Constrain focus to tabbable elements [IE 11 fix] #2988

merged 1 commit into from Mar 25, 2019

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Mar 25, 2019 •
edited

Preview ✨

This applies the same technique to the 2.0 branch that we applied in the 1.x branch here: #2983

Now, IE 11 won't apply focus highlighting to non-tabbable elements.

Before:
Screen Shot 2019-03-25 at 4 37 55 AM

After:
Screen Shot 2019-03-25 at 4 33 56 AM

Fixes #2928

@thisisdano thisisdano requested a review from a team March 25, 2019 11:29
@maya maya merged commit 0079316 into release-2.0 Mar 25, 2019
@maya maya deleted the dw-update-focus branch March 25, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya maya maya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisdano @maya