Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unstyled button and list to BEM #2974

Merged
merged 17 commits into from Mar 20, 2019
Merged

Update unstyled button and list to BEM #2974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8506935
Update template to show unstyled variant
thisisdano Mar 13, 2019
76ee144
Add more overrides
thisisdano Mar 13, 2019
97691ea
Add unstyled variants to other button classes
thisisdano Mar 13, 2019
e8fa765
Update todos
thisisdano Mar 13, 2019
304a116
Show unstyled variant for button--big
thisisdano Mar 14, 2019
489d558
Use inverse colors for unstyled.inverse
thisisdano Mar 14, 2019
9f92278
Updated list markup to use BEM
thisisdano Mar 14, 2019
5d7761c
Add an unstyled list example
thisisdano Mar 14, 2019
7bf5f45
Update footer styles to use BEM
thisisdano Mar 14, 2019
cda366a
Added ustyled list BEM styles and moved line height to the list level…
thisisdano Mar 14, 2019
8b7b56c
Use transparent as bg for outline buttons
thisisdano Mar 18, 2019
d4fc62d
Merge branch 'release-2.0' into dw-update-unstyled-classes
thisisdano Mar 18, 2019
275f10b
Update package-lock.json
thisisdano Mar 18, 2019
81f3b35
Merge branch 'release-2.0' into dw-update-unstyled-classes
thisisdano Mar 20, 2019
64c623d
Remove todo
thisisdano Mar 20, 2019
ea52539
Update btn unstyled mixin and remove CSS nesting
maya Mar 20, 2019
82b661b
Merge pull request #2976 from uswds/mb-update-btn-unstyled
Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
82 changes: 60 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions spec/unit/footer/template.html
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
<div class="usa-footer__primary-section">
<div class="usa-grid">
<nav class="usa-footer__nav usa-width-two-thirds">
<ul class="usa-unstyled-list usa-width-one-fourth usa-footer__primary-content">
<ul class="usa-list usa-list--unstyled usa-width-one-fourth usa-footer__primary-content">
<li class="usa-footer__primary-link">
<h4>Topic</h4>
</li>
Expand All @@ -14,7 +14,7 @@ <h4>Topic</h4>
<li><a href="javascript:void(0);">Secondary link</a></li>
<li><a href="javascript:void(0);">Secondary link</a></li>
</ul>
<ul class="usa-unstyled-list usa-width-one-fourth usa-footer__primary-content">
<ul class="usa-list usa-list--unstyled usa-width-one-fourth usa-footer__primary-content">
<li class="usa-footer__primary-link">
<h4>Topic</h4>
</li>
Expand All @@ -23,7 +23,7 @@ <h4>Topic</h4>
<li><a href="javascript:void(0);">Secondary link</a></li>
<li><a href="javascript:void(0);">Secondary link</a></li>
</ul>
<ul class="usa-unstyled-list usa-width-one-fourth usa-footer__primary-content">
<ul class="usa-list usa-list--unstyled usa-width-one-fourth usa-footer__primary-content">
<li class="usa-footer__primary-link">
<h4>Topic</h4>
</li>
Expand All @@ -32,7 +32,7 @@ <h4>Topic</h4>
<li><a href="javascript:void(0);">Secondary link</a></li>
<li><a href="javascript:void(0);">Secondary link</a></li>
</ul>
<ul class="usa-unstyled-list usa-width-one-fourth usa-footer__primary-content">
<ul class="usa-list usa-list--unstyled usa-width-one-fourth usa-footer__primary-content">
<li class="usa-footer__primary-link">
<h4>Topic</h4>
</li>
Expand Down
13 changes: 8 additions & 5 deletions src/components/01-type/lists.njk
View file
Open in desktop
@@ -1,26 +1,29 @@

<div class="grid-row grid-gap">
<div class="mobile-lg:grid-col-4">

<h6 class="usa-heading-alt">Unordered list</h6>

<ul class="usa-list">
<li>Unordered list item</li>
<li>Unordered list item</li>
<li>Unordered list item</li>
</ul>

</div>

<div class="mobile-lg:grid-col-4">

<h6 class="usa-heading-alt">Ordered list</h6>

<ol class="usa-list">
<li>Ordered list item</li>
<li>Ordered list item</li>
<li>Ordered list item</li>
</ol>
</div>

<div class="mobile-lg:grid-col-4">
<h6 class="usa-heading-alt">Unstyled list</h6>
<ul class="usa-list usa-list--unstyled">
<li>Unstyled list item</li>
<li>Unstyled list item</li>
<li>Unstyled list item</li>
</ul>
</div>
</div>