Update node and npm versions in README [2.0] #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maya
changed the title
maya
commented
Mar 18, 2019
README.md
Outdated
| @@ -129,15 +129,15 @@ And that’s it — you should now be able to copy our code samples into your `i | |||
|
|
|||
| 1. Install `Node/npm`. Below is a link to find the install method that coincides with your operating system: | |||
|
|
|||
| - Node v4.2.3+, [Installation guides](https://nodejs.org/en/download/) | |||
| - Node v10.15.1+, [Installation guides](https://nodejs.org/en/download/) | |||
There was a problem hiding this comment.
Do we know if anything above 10 works? e.g. does node 11 work?
There was a problem hiding this comment.
Updated to be explicitly node 10 in f65e9fb.
|
The circleci config is still using a node 8 image so we should bump that too. @maya Do you want to make that change in the PR or do it separately? |
|
@saracope We can do it in a separate PR. |
|
Also, what's the proper way to do that? Right now, it's |
|
Yeah |
saracope
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node and npm versions to what we currently use in the README.
Semi-related to #2954.