Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten the letterspacing of letterspacing 1 #2965

Merged
merged 1 commit into from Mar 18, 2019
Merged

Tighten the letterspacing of letterspacing 1 #2965

merged 1 commit into from Mar 18, 2019

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Mar 18, 2019 •
edited

No preview

Uses 0.025 for the letter-spacing value of letterspacing 1 to address the issue in #2962

Fixes #2962

@thisisdano thisisdano requested a review from a team March 18, 2019 17:15
maya
maya approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@maya maya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But also, I think our styleguide uses leading zeros so want to check if they should be added here, or any other place they may be missing?

@maya maya merged commit 637b3ba into release-2.0 Mar 18, 2019
@maya maya deleted the dw-update-letterspacing branch March 18, 2019 17:36
@maya maya mentioned this pull request Mar 18, 2019
Closed
@thisisdano
Copy link
Member Author

You're right — we should check for non-leading zeroes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya maya maya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisdano @maya