Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all for media queries instead of screen only #2910

Merged
merged 2 commits into from Feb 15, 2019
Merged

Use all for media queries instead of screen only #2910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64c9f0
Use `all` for media queries instead of screen only
thisisdano Feb 15, 2019
bb97178
Add space after comment
thisisdano Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/stylesheets/core/mixins/_at-media.scss
View file
Open in desktop
@@ -1,4 +1,5 @@
// Mobile-first media query helper

@mixin at-media($bp) {
$quoted-bp: smart-quote($bp);
$our-breakpoints: map-deep-get($system-properties, breakpoints, standard);
Expand All @@ -13,7 +14,7 @@
@else {
@warn '`#{$bp}` is not a valid USWDS project breakpoint. Valid values: #{map-keys($our-breakpoints)}';
}
@media screen and (min-width: #{$bp}) {
@media all and (min-width: #{$bp}) {
@content;
}
}
Expand All @@ -33,7 +34,7 @@
@else {
@warn '`#{$bp}` is not a valid USWDS project breakpoint. Valid values: #{map-keys($our-breakpoints)}';
}
@media screen and (max-width: #{$bp}) {
@media all and (max-width: #{$bp}) {
@content;
}
}