Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :visited classing from buttons #2827

Merged
merged 10 commits into from Oct 11, 2018
Merged

Remove :visited classing from buttons #2827

merged 10 commits into from Oct 11, 2018

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Oct 5, 2018

馃攳 Preview

This is a little difficult to preview and reproduce. You need to manually change the buttons in the preview to be as instead of buttons and then preview with :visited. This also fixes an additional bug I noticed with the :active state with a buttons.

@thisisdano thisisdano changed the base branch from develop to release-2.0 October 5, 2018 23:12
@thisisdano
Copy link
Member Author

Updated to remove the :not() rule since it was adding too much specificity. I went back and just focussed on the usa-button styles.

@thisisdano thisisdano requested a review from a team October 10, 2018 22:00
@thisisdano
Copy link
Member Author

@saracope Tagging you in on this one for review!

@thisisdano thisisdano merged commit 7a09fff into release-2.0 Oct 11, 2018
@thisisdano thisisdano deleted the dw-fix-buttons branch October 11, 2018 18:19
@thisisdano thisisdano mentioned this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants