New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 Beta 1 - Button variations not working #2817
Comments
Can you tell me a bit more about how to reproduce this? I see the proper button variations on https://v2.designsystem.digital.gov/components/buttons/ |
Took me a minute to reprocude, but it turns out that button-visited wipes out the modifiers. Since those on the demo page don't have an action associated with them, you can't reproduce it. I put two buttons on Project Corsair and you will see once you click them, they revert to button-visited. |
Oof. Buttons shouldn't have a |
OK, I've got a fix here if you want to check it out: #2827 |
Integrated the changes and buttons are working as expected, but the links that are not buttons in the mobile menu are now impacted. |
Updated! |
@stphnwlkr Does the updated solution in #2827 work for you? |
Fixed in #2827 |
When using usa-button and then a modifier, the modifiers are not overiding the background colors. I had to add !important to all the button-secondary modifiers for them to work.
The text was updated successfully, but these errors were encountered: