Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Identifier: Add changelog and demo identifier content fix #2610

Open
wants to merge 7 commits into
base: release-3.8.1
Choose a base branch
from

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 9, 2024

Summary

Important

The uswds/uswds#al-identifier-spanish-html branch was installed to demonstrate the fix from uswds/uswds#5857. We should uninstall this branch before merging.

Related issue

Related to issue uswds/uswds#5857

Preview link

Testing and review

  • Confirm the changelog is accurate and makes sense
  • Confirm that the component previews for Spanish variants of the component Do not include the word "An"

package.json Outdated
@@ -102,6 +102,6 @@
"snyk": true,
"dependencies": {
"@uswds/compile": "^1.1.0",
"@uswds/uswds": "3.8.0"
"@uswds/uswds": "github:uswds/uswds#al-identifier-spanish-html"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

This needs to be reverted before merge

@amyleadem amyleadem changed the base branch from main to release-3.8.1 May 3, 2024 20:48
@amyleadem amyleadem marked this pull request as ready for review May 7, 2024 16:59
@amyleadem amyleadem requested a review from mahoneycm May 7, 2024 16:59
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants