New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Accordion: Add accordion color settings #2081
USWDS-Site - Accordion: Add accordion color settings #2081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, @mejiaj ! I added comments for a couple possible changes. Let me know if you have questions:
Checks performed:
- Confirmed the updated settings match the updates from USWDS - Accordion: Add color settings uswds#5269
- Checked for grammar and spelling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on my end!
I agree with @amyleadem comments to add the setting names to the change log as well as the adjustments to the setting's descriptions for improved clarity.
No further adjustments!
- Checked for changelog items on Accordion and Settings page
- Checked for setting's descriptions on Accordion page
- Checked for new accordion settings on Settings page
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Based on comment in #2081 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had one question related to affectsSettings
.
|
ddcce60
into
dw-changelog-button-outline-whc
Summary
Documenting new accordion color settings & updating changelog entries.
Related issue
Part of uswds/uswds#5269.
Preview link
Preview link:
Problem statement
Settings and changelog entries need to be updated for accuracy.
Solution
_data/settings/components/accordion.yml
Testing and review
Accordion component
Settings page