Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Margin and padding: Add missing utilities #1940

Merged
merged 7 commits into from Mar 1, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Dec 8, 2022

Summary

Updated the "Margin and padding" documentation to show the "medium-negative" margins that were added to the default set in #4212..

Specifically:

  • Added tokens neg-4 through neg-15, and 10 through 15 to the example set because they exist in the USWDS margin defaults but were not included on the page.
  • Changed the size of the example rectangles so that they could properly display the "medium-negative" margin sizes.
  • Fixed the broken display on the examples in the "Padding on all sides" section

⚠️ Before merge, we must update the changelog data with the correct date.

Related issue

Closes #1927

Preview link

Preview link: Margin and padding utility page

Testing and review

Please confirm that all the "medium negative" margin utilities are accounted for in the documentation and that the visual examples make sense and are accurate.

@amyleadem amyleadem changed the title USWDS-Site: Add medium negative margins USWDS-Site - Margin and padding: Add missing utilities Dec 21, 2022
@amyleadem amyleadem marked this pull request as ready for review December 21, 2022 15:58
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked for code style and formatting and visual display issues.

Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisdano thisisdano merged commit 69b1c9f into main Mar 1, 2023
@thisisdano thisisdano deleted the al-neg-margin branch March 1, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Margin and padding utility: Add medium-negative margins
3 participants