USWDS-Site: Update incorrect success-dark color token values #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
changed the title
mahoneycm
approved these changes
Dec 8, 2022
|
@mahoneycm I did an initial sweep of the color values for tokens and settings, which is how I caught |
mejiaj
approved these changes
Dec 19, 2022
| kind: color | ||
| - name: success-darker | ||
| subsection: state color token | ||
| usage: Use grades 70-80. | ||
| var: $theme-color-success-darker | ||
| default: "'green-cool-60'" | ||
| default: "'green-cool-60v'" | ||
| kind: color | ||
|
|
||
| - name: Info color family |
There was a problem hiding this comment.
Ran a quick test on all color values and this all looks correct now. Thanks for fixing!
amyleadem
changed the title
thisisdano
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
success-darkfromgreen-cool-50togreen-cool-50vandsuccess-darkerfromgreen-cool-60togreen-cool-60vto match current USWDS value.success-darkto vivid variant uswds#4183$theme-color-accent-warm-darkerfromorange-60vtoorange-60to match current USWDS value.Related issue
Closes #1926
Preview links
Test and review
Outstanding question
There is a mismatch between the default value and the recommended color grades. I have opened up issue #1941 to assess if we should update either the recommended values or the defaults.