Add ZSTD decompression support #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolukhin
requested changes
May 20, 2024
universal/src/compression/zstd.cpp
Outdated
| cur_pos += input.size; | ||
| } | ||
|
|
||
| ZSTD_freeDStream(stream); |
There was a problem hiding this comment.
Use RAII for that to avoid resource leaks
'В случае если content_encoding != "gzip" и content_encoding != "zstd" тело запроса потрётся :('
botanegg
reviewed
May 24, 2024
universal/src/compression/zstd.cpp
Outdated
| } | ||
|
|
||
| auto stream_del = [](ZSTD_DStream* ptr) { ZSTD_freeDStream(ptr); }; | ||
| auto stream_guard = |
There was a problem hiding this comment.
seems like you can move up this guard to line after ZSTD_createDStream
also ZSTD_freeDStream accept NULL pointer
botanegg
reviewed
May 24, 2024
universal/src/compression/zstd.cpp
Outdated
| throw TooBigError(); | ||
| } | ||
| if (decompressed_size > std::numeric_limits<int64_t>::max() / 2) { | ||
| return DecompressStream(compressed, max_size); |
There was a problem hiding this comment.
Are you sure you want to decompress more than 4611686018427387903 bytes?
seems like a sign mismatch here for <>
also decompressed_size is unsigned long long
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #549
Benchmark results: