Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various logs-dispatcher fixes #10

Merged
merged 4 commits into from Nov 23, 2022
Merged

Various logs-dispatcher fixes #10

merged 4 commits into from Nov 23, 2022

Conversation

smlx
Copy link
Member

@smlx smlx commented Nov 21, 2022

  • Pin the dependency tree using bundler.
  • Bump all gems to latest version.
  • Bump fluentd base image to latest version.

@tobybellwood
Copy link
Member

I'd much prefer specifying the version in the Gemfile (maybe even with a carat for minor version compatibility) and not committing the vendor dir. The result will be the same, but it will allow automated updates to be PR'd, and make updates less manual.

I've got the change(s) if you want them?

gem 'fluent-plugin-cloudwatch-logs', '~> 0.14.3'
gem 'fluent-plugin-datadog', '~> 0.14.2'
gem 'fluent-plugin-kubernetes_metadata_filter', '~> 3.1.2'
gem 'fluent-plugin-multi-format-parser', '~> 1.0.0'
gem 'fluent-plugin-prometheus', '~> 2.0.3'
gem 'fluent-plugin-rabbitmq', '~> 0.0.9'
gem 'fluent-plugin-record-modifier', '~> 2.1.1'
gem 'fluent-plugin-remote-syslog', '~> 1.1'
gem 'fluent-plugin-rewrite-tag-filter', '~> 2.4.0'
gem 'fluent-plugin-route', '~> 1.0.0'
gem 'fluent-plugin-s3', '~> 1.7.2'
gem 'fluent-plugin-splunk-enterprise', '~> 0.10.2'
gem 'fluent-plugin-sumologic_output', '~> 1.8.0'

@smlx
Copy link
Member Author

smlx commented Nov 22, 2022

Thanks for taking a look. I can remove the vendored gems if you like, but it might be a good idea to leave them in. The advantages of vendoring include:

  • Gems are guaranteed not to change instead of relying on a version number.
  • Build don't depend on rubygems.org being up.

Dependabot supports vendoring the gems, so automated upgrades shouldn't be too difficult?

Limiting the versions to minor upgrades (which is what ~> does) may also cause problems due to missing major version upgrades. e.g. v3 of the k8s metadata plugin was a breaking change (it broke our config!) but it also has important fixes for recent versions of k8s that we need.

Let me know what you think 🙂

This pins gems and avoids ad-hoc gem upgrades during image build.
smlx added a commit to uselagoon/lagoon-charts that referenced this pull request Nov 23, 2022
This is a temporary change until this PR is made available in a release:
uselagoon/lagoon-service-images#10
smlx added a commit to uselagoon/lagoon-charts that referenced this pull request Nov 23, 2022
This is a temporary change until this PR is made available in a release:
uselagoon/lagoon-service-images#10
smlx added a commit to uselagoon/lagoon-charts that referenced this pull request Nov 23, 2022
This is a temporary change until this PR is made available in a release:
uselagoon/lagoon-service-images#10
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup - happy now!

@smlx smlx merged commit 340d15e into main Nov 23, 2022
@smlx smlx deleted the fix-logs-dispatcher branch November 23, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants