New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various logs-dispatcher fixes #10
Conversation
smlx
commented
Nov 21, 2022
•
edited
edited
- Pin the dependency tree using bundler.
- Bump all gems to latest version.
- Bump fluentd base image to latest version.
I'd much prefer specifying the version in the Gemfile (maybe even with a carat for minor version compatibility) and not committing the vendor dir. The result will be the same, but it will allow automated updates to be PR'd, and make updates less manual. I've got the change(s) if you want them?
|
Thanks for taking a look. I can remove the vendored gems if you like, but it might be a good idea to leave them in. The advantages of vendoring include:
Dependabot supports vendoring the gems, so automated upgrades shouldn't be too difficult? Limiting the versions to minor upgrades (which is what Let me know what you think 🙂 |
c8d4cf2
to
7402d43
Compare
This pins gems and avoids ad-hoc gem upgrades during image build.
Also add jq for testing purposes.
7402d43
to
dfd3acd
Compare
This is a temporary change until this PR is made available in a release: uselagoon/lagoon-service-images#10
This is a temporary change until this PR is made available in a release: uselagoon/lagoon-service-images#10
This is a temporary change until this PR is made available in a release: uselagoon/lagoon-service-images#10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup - happy now!