New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 4502 #485
Update 4502 #485
Conversation
…stent display across screen sizes
…riables to theme settings, edit in use color variables to match
@ButtersUSDS @humancompanion-usds Would love y'all's review on the above changes. I updated our logo and brand colors, updated USWDS, and moved a few things around in the SASS. If you're swamped this week, is there another person I can flag? 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drew-usds - I was able to get your branch running. I'll make a pull request to improve the README (I needed to run bundle install which isn't listed there), but it was fairly painless.
I checked out the changes you made and they look fine though I may file a few issues with the site itself that I discovered when looking at it at mobile widths.
I did get some warnings when firing up the site that you may want to look at:
Configuration file: /Users/mjdingee/Documents/repos/usds-website/_config.yml
Source: /Users/mjdingee/Documents/repos/usds-website
Destination: /Users/mjdingee/Documents/repos/usds-website/_site
Incremental build: disabled. Enable with --incremental
Generating...
Jekyll Feed: Generating feed for posts
WARNING: Override: `#5d5d5d` is not a USWDS color token.
on line 916 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_functions.scss, in `color'
from line 275 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_variables.scss
from line 16 of an unknown file
WARNING: Override: `#3f3f3f` is not a USWDS color token.
on line 916 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_functions.scss, in `color'
from line 276 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_variables.scss
from line 16 of an unknown file
@drew-usds - I thought perhaps I needed to run
|
Thanks, sir! Greatly appreciate documenting those mobile bugs. Ah yes, those errors! This PR updates uswds to the most recent version, which lets you override theme colors with things that are not uswds color tokens. This is letting us use our current brand colors without a bunch of |
Website updates from #4502!!!
/projects/discharge-upgrade-tool
,/projects/blue-button-2
, and/projects/n-400
(Content here).2.4.0
Update USWDS to 2.4.0 #486/events
, redirect to/news-and-blog
Remove /events page #487