Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4502 #485

Merged
merged 23 commits into from Jan 15, 2020
Merged

Update 4502 #485

merged 23 commits into from Jan 15, 2020

Conversation

drew-usds
Copy link
Contributor

@drew-usds drew-usds commented Dec 30, 2019

Website updates from #4502!!!

  • Nav logo swapped to current horizontal version (further detail here).
  • Edits to nav layout/css for more consistent responsive display.
  • Footer logo swapped to current version.
  • Color variables updated to match brand standards (detail here. See billboard and footer for in-use ex).
  • Updates to sidebar/impact project content for /projects/discharge-upgrade-tool, /projects/blue-button-2, and /projects/n-400 (Content here).
  • Updated project show template to exclude the current post from the "related" carousel.
  • Updated USWDS to 2.4.0 Update USWDS to 2.4.0 #486
  • Temporarily remove /events, redirect to /news-and-blog Remove /events page #487
  • Refactor color variable use, move into theme settings file and edit in-use variables where needed.

@drew-usds
Copy link
Contributor Author

drew-usds commented Jan 13, 2020

@ButtersUSDS @humancompanion-usds

Would love y'all's review on the above changes. I updated our logo and brand colors, updated USWDS, and moved a few things around in the SASS.

If you're swamped this week, is there another person I can flag?

🙌

@drew-usds drew-usds self-assigned this Jan 13, 2020
@drew-usds drew-usds requested review from humancompanion-usds and removed request for davidholmesusds January 15, 2020 16:11
Copy link
Contributor

@humancompanion-usds humancompanion-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drew-usds - I was able to get your branch running. I'll make a pull request to improve the README (I needed to run bundle install which isn't listed there), but it was fairly painless.

I checked out the changes you made and they look fine though I may file a few issues with the site itself that I discovered when looking at it at mobile widths.

I did get some warnings when firing up the site that you may want to look at:

Configuration file: /Users/mjdingee/Documents/repos/usds-website/_config.yml
            Source: /Users/mjdingee/Documents/repos/usds-website
       Destination: /Users/mjdingee/Documents/repos/usds-website/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
       Jekyll Feed: Generating feed for posts
WARNING: Override: `#5d5d5d` is not a USWDS color token.
         on line 916 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_functions.scss, in `color'
         from line 275 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_variables.scss
         from line 16 of an unknown file

WARNING: Override: `#3f3f3f` is not a USWDS color token.
         on line 916 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_functions.scss, in `color'
         from line 276 of /Users/mjdingee/Documents/repos/usds-website/assets/uswds-sass/core/_variables.scss
         from line 16 of an unknown file

@humancompanion-usds
Copy link
Contributor

@drew-usds - I thought perhaps I needed to run gulp uswds-build-sass before serving up the site to make those errors go away. But instead that command fails on this branch:

usds-website [update-4502] gulp uswds-build-sass
[13:39:04] Using gulpfile ~/Documents/repos/usds-website/gulpfile.js
[13:39:04] Starting 'uswds-build-sass'...
[13:39:06] 'uswds-build-sass' errored after 2.18 s
[13:39:06] Error in plugin "gulp-sass"
Message:
    node_modules/uswds/dist/scss/core/_functions.scss
Error: Only use quoted color tokens in USWDS functions and mixins. See v2.designsystem.digital.gov/style-tokens/color for more information.
        on line 130 of node_modules/uswds/dist/scss/core/_functions.scss, in function `smart-quote`
        from line 924 of node_modules/uswds/dist/scss/core/_functions.scss, in function `color`
        from line 294 of node_modules/uswds/dist/scss/core/_variables.scss
        from line 28 of node_modules/uswds/dist/scss/uswds.scss
        from line 63 of assets/uswds-theme/styles.scss
>>     @error 'Only use quoted color tokens in USWDS functions and mixins. '

   ----^

Details:
    status: 1
    file: /Users/mjdingee/Documents/repos/usds-website/node_modules/uswds/dist/scss/core/_functions.scss
    line: 130
    column: 5
    formatted: Error: Only use quoted color tokens in USWDS functions and mixins. See v2.designsystem.digital.gov/style-tokens/color for more information.
        on line 130 of node_modules/uswds/dist/scss/core/_functions.scss, in function `smart-quote`
        from line 924 of node_modules/uswds/dist/scss/core/_functions.scss, in function `color`
        from line 294 of node_modules/uswds/dist/scss/core/_variables.scss
        from line 28 of node_modules/uswds/dist/scss/uswds.scss
        from line 63 of assets/uswds-theme/styles.scss
>>     @error 'Only use quoted color tokens in USWDS functions and mixins. '

   ----^

    messageFormatted: node_modules/uswds/dist/scss/core/_functions.scss
Error: Only use quoted color tokens in USWDS functions and mixins. See v2.designsystem.digital.gov/style-tokens/color for more information.
        on line 130 of node_modules/uswds/dist/scss/core/_functions.scss, in function `smart-quote`
        from line 924 of node_modules/uswds/dist/scss/core/_functions.scss, in function `color`
        from line 294 of node_modules/uswds/dist/scss/core/_variables.scss
        from line 28 of node_modules/uswds/dist/scss/uswds.scss
        from line 63 of assets/uswds-theme/styles.scss
>>     @error 'Only use quoted color tokens in USWDS functions and mixins. '

   ----^

    messageOriginal: Only use quoted color tokens in USWDS functions and mixins. See v2.designsystem.digital.gov/style-tokens/color for more information.
    relativePath: node_modules/uswds/dist/scss/core/_functions.scss
    domainEmitter: [object Object]
    domainThrown: false

@drew-usds
Copy link
Contributor Author

drew-usds commented Jan 15, 2020

@humancompanion-usds

Thanks, sir! Greatly appreciate documenting those mobile bugs.

Ah yes, those errors! This PR updates uswds to the most recent version, which lets you override theme colors with things that are not uswds color tokens.

This is letting us use our current brand colors without a bunch of default!s or important!s, but it does throw those annoying errors. They say that they can be suppressed with $theme-show-notifications: false, but it didn't seem to make a difference. Will open an issue to look into turning them off for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants