Add xfails for CPython 3.13.0a5 #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-v
added
the
Skip Changelog
sethmlarson
reviewed
Mar 28, 2024
| @@ -77,6 +78,10 @@ def teardown_class(cls) -> None: | |||
| super().teardown_class() | |||
| shutil.rmtree(cls.certs_dir) | |||
|
|
|||
| @pytest.mark.xfail( | |||
There was a problem hiding this comment.
There's a lot of duplication, can we create a marker and reuse it?
When there is a new trustme release, we can pin the package to it instead of to the commit The xfails can be dropped when Python 3.13 alpha 6 is available; the expected release date is April 9th + maybe a few days for GitHub Actions to provide the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3366
xfails in
test/with_dummyserver/test_proxy_poolmanager.pycan be dropped when CPython 3.13.0a6 is available.