backport HTTPConnection._tunnel from 3.11.4 to unignore remaining ResourceWarnings #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
backport-tunnel-from-3-11-4
branch
from
15ad8cd
to
7d5ee4b
Compare
graingert
changed the title
graingert
force-pushed
the
backport-tunnel-from-3-11-4
branch
from
6b462dc
to
42e444f
Compare
|
@graingert I would love to avoid bundling the |
|
@sethmlarson but this is a warning emitted for users of urllib3 on 3.10 and I'd like the warning fixed for those people too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the fix from python/cpython#103472 in 3.11.4 so that the last ignored ResourceWarnings are no longer issued by urllib3