Factorize hypercon.Config() creation #3234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
the
Skip Changelog
|
@pquentin Looks like potential failures on the certificate tests, might be related? |
|
Definitely related, thanks. |
graingert
reviewed
Jan 7, 2024
| @@ -62,7 +76,7 @@ def run_hypercorn_in_thread( | |||
| if not ready_event.is_set(): | |||
| raise Exception("most likely failed to start server") | |||
|
|
|||
| yield | |||
| yield typing.cast(int, parse_url(config.bind[0]).port) | |||
There was a problem hiding this comment.
Suggested change
| yield typing.cast(int, parse_url(config.bind[0]).port) | |
| port = parse_url(config.bind[0]).port | |
| assert port is not None | |
| yield port |
graingert
reviewed
Jan 7, 2024
| config: hypercorn.Config, app: hypercorn.typing.ASGIFramework | ||
| ) -> Generator[None, None, None]: | ||
| host: str, certs: dict[str, typing.Any] | None, app: hypercorn.typing.ASGIFramework | ||
| ) -> typing.Iterator[int]: |
There was a problem hiding this comment.
Iterator is technically the wrong type, because contextmanager incorrectly accepts an object without .throw. This bug might get fixed in typeshed
Suggested change
| ) -> typing.Iterator[int]: | |
| ) -> Generator[int, None, None] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the same changes ready for #3230, I'll update whichever pull request gets merged last.