Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connecting with proxy trailing '.' fix #3183

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Connecting with proxy trailing '.' fix #3183

merged 1 commit into from
Nov 21, 2023
+15 −2

Conversation

sg3-141-592
Copy link
Contributor

@sg3-141-592 sg3-141-592 commented Nov 6, 2023 •
edited

Candidate fix for #2244

This change strips the trailing '.' for proxy requests and adds a new unit test to ensure we can correctly fetch from localhost.

@sg3-141-592 sg3-141-592 force-pushed the proxy_fqdn_fix branch 3 times, most recently from 596da4f to 3651ccd Compare November 6, 2023 19:52
@sg3-141-592 sg3-141-592 marked this pull request as ready for review November 7, 2023 06:47
illia-v
illia-v approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@illia-v illia-v linked an issue Nov 21, 2023 that may be closed by this pull request
Hostname matching doesn't strip trailing '.' when connecting with proxy #2244
Closed
@illia-v illia-v merged commit e29f504 into urllib3:main Nov 21, 2023
27 of 33 checks passed
@illia-v
Copy link
Member

illia-v commented Nov 21, 2023

Thanks @sg3-141-592!
#2244 is covered by a $100 bounty, please submit an expense to Open Collective if you’re able to receive funds for working on OSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illia-v illia-v illia-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hostname matching doesn't strip trailing '.' when connecting with proxy
2 participants
@sg3-141-592 @illia-v