Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26] Configure CPython 3.12 in CI #3157

Draft
wants to merge 1 commit into
base: 1.26.x
Choose a base branch
from
Draft

[1.26] Configure CPython 3.12 in CI #3157

wants to merge 1 commit into from

Conversation

illia-v
Copy link
Member

@illia-v illia-v commented Oct 17, 2023

No description provided.

@illia-v illia-v added the Skip Changelog Pull requests that don't require a changelog entry label Oct 17, 2023
@illia-v
Copy link
Member Author

illia-v commented Oct 17, 2023

I canceled the CI workflow because some jobs hasn't finished in 2 hours

@sethmlarson sethmlarson reopened this Oct 30, 2023
@illia-v
Copy link
Member Author

illia-v commented Nov 24, 2023 •
edited

This is a comment for #3156 posted here accidentally

The tests won't succeed until a new version of CFFI is released most likely
python-cffi/cffi#23 (comment)

@pquentin
Copy link
Member

pquentin commented Nov 28, 2023 •
edited

Or when Python 3.13 alpha 2 is out: python/cpython#112026 (comment)

Edit: wait, this issue is about Python 3.13, not 3.12.

@illia-v
Copy link
Member Author

illia-v commented Nov 28, 2023

@pquentin I wanted to post the comment in #3156 😄

The latest CI run there used 3.13.0a2, but it failed without the CFFI patch https://github.com/urllib3/urllib3/actions/runs/6872478062/job/18998233027?pr=3156

@pquentin pquentin mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@pquentin pquentin Awaiting requested review from pquentin pquentin will be requested when the pull request is marked ready for review pquentin is a code owner

@shazow shazow Awaiting requested review from shazow shazow will be requested when the pull request is marked ready for review shazow is a code owner

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illia-v @pquentin @sethmlarson